Re: [PATCH v1 1/4] ASoC: Intel: bytcht_es8316: Get platform data via dev_get_platdata()

From: Pierre-Louis Bossart
Date: Wed Oct 06 2021 - 12:13:54 EST




On 10/6/21 10:04 AM, Andy Shevchenko wrote:
> Access to platform data via dev_get_platdata() getter to make code cleaner.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

For the series

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>

FWIW Marc likes a cover letter that's kept in the merge logs.

> ---
> sound/soc/intel/boards/bytcht_es8316.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index 1bb9b8e7bcc7..4360519fbb0c 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -456,12 +456,12 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = {
>
> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> {
> + struct device *dev = &pdev->dev;
> static const char * const mic_name[] = { "in1", "in2" };
> + struct snd_soc_acpi_mach *mach = dev_get_platdata(dev);
> struct property_entry props[MAX_NO_PROPS] = {};
> struct byt_cht_es8316_private *priv;
> const struct dmi_system_id *dmi_id;
> - struct device *dev = &pdev->dev;
> - struct snd_soc_acpi_mach *mach;
> struct fwnode_handle *fwnode;
> const char *platform_name;
> struct acpi_device *adev;
> @@ -476,7 +476,6 @@ static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - mach = dev->platform_data;
> /* fix index of codec dai */
> for (i = 0; i < ARRAY_SIZE(byt_cht_es8316_dais); i++) {
> if (!strcmp(byt_cht_es8316_dais[i].codecs->name,
>