Re: [PATCH v4 09/11] media: dt-bindings: Make sure items in data-lanes are unique

From: Laurent Pinchart
Date: Wed Oct 06 2021 - 19:47:58 EST


Hi Pratyush,

Thank you for the patch.

On Wed, Sep 15, 2021 at 05:32:38PM +0530, Pratyush Yadav wrote:
> The data-lanes property maps the logical lane numbers to the physical
> lane numbers. The position of an entry is the logical lane number and
> its value is the physical lane number. Since one physical lane can only
> map to one logical lane, no number in the list should repeat. Add the
> uniqueItems constraint on the property to enforce this.
>
> Signed-off-by: Pratyush Yadav <p.yadav@xxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>
> Changes in v4:
> - New in v4.
>
> Documentation/devicetree/bindings/media/video-interfaces.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> index 4391dce2caee..4bce93efae5f 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> @@ -158,6 +158,7 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 1
> maxItems: 8
> + uniqueItems: true
> items:
> # Assume up to 9 physical lane indices
> maximum: 8

--
Regards,

Laurent Pinchart