Re: [PATCH 5/9] of: add self parameter to of_update_property()

From: Greg Kroah-Hartman
Date: Thu Oct 07 2021 - 01:26:13 EST


On Wed, Oct 06, 2021 at 05:09:50PM -0700, Zev Weiss wrote:
> --- a/drivers/of/of_private.h
> +++ b/drivers/of/of_private.h
> @@ -64,7 +64,7 @@ int of_node_is_attached(struct device_node *node);
> int __of_add_property_sysfs(struct device_node *np, struct property *pp);
> void __of_remove_property_sysfs(struct device_node *np, struct property *prop);
> void __of_update_property_sysfs(struct device_node *np, struct property *newprop,
> - struct property *oldprop);
> + struct property *oldprop, bool self);

Again, not a good api decision at all

thanks,

greg k-h