Re: [PATCH v1 3/3] kernel.h: Split out container_of() and typeof_memeber() macros
From: Andy Shevchenko
Date: Thu Oct 07 2021 - 06:01:06 EST
On Thu, Oct 07, 2021 at 12:20:58PM +0300, Andy Shevchenko wrote:
> On Tue, Jul 13, 2021 at 08:39:22PM +0200, Miguel Ojeda wrote:
> > On Tue, Jul 13, 2021 at 1:23 PM Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > Life is messy and can not easily be partitioned into tiny pieces. That
> > > way usually ends up being even messier in the end...
> >
> > I agree measurements would be ideal.
> >
> > Having said that, even if it makes no performance difference, I think
> > it is reasonable to split things (within reason) and makes a bunch of
> > other things easier, plus sometimes one can enforce particular
> > conventions in the separate header (like I did when introducing
> > `compiler_attributes.h`).
>
> It does almost 2% (steady) speedup. I will send a v2 with methodology
> and numbers of testing.
Seems it's slightly different Cc list, so TWIMC the v2 is here:
https://lore.kernel.org/linux-media/20211007095129.22037-5-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u
--
With Best Regards,
Andy Shevchenko