Re: [PATCH] ASoC: wcd938x: Fix jack detection issue

[Srinivas Kandagatla]

On 07/10/2021 14:50, Srinivasa Rao Mandadapu wrote:
> This patch is to fix audio 3.5mm jack detection failure
> on wcd938x codec based target.
>
> Fixes: bcee7ed09b8e (ASoC: codecs: wcd938x: add Multi Button Headset Control support)
>
> Signed-off-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx>

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

> ---
>   sound/soc/codecs/wcd938x.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
> index f0daf8d..52de7d1 100644
> --- a/sound/soc/codecs/wcd938x.c
> +++ b/sound/soc/codecs/wcd938x.c
> @@ -4144,10 +4144,10 @@ static int wcd938x_codec_set_jack(struct snd_soc_component *comp,
>   {
>   	struct wcd938x_priv *wcd = dev_get_drvdata(comp->dev);
>   
> -	if (!jack)
> +	if (jack)
>   		return wcd_mbhc_start(wcd->wcd_mbhc, &wcd->mbhc_cfg, jack);
> -
> -	wcd_mbhc_stop(wcd->wcd_mbhc);
> +	else
> +		wcd_mbhc_stop(wcd->wcd_mbhc);
>   
>   	return 0;
>   }