Re: [PATCH v6 4/6] drivers: iio: dac: ad5766: Fix dt property name
From: Jonathan Cameron
Date: Thu Oct 07 2021 - 11:47:28 EST
On Thu, 7 Oct 2021 08:00:34 +0000
Mihail Chindris <mihail.chindris@xxxxxxxxxx> wrote:
> In the documentation the name for the property is
> output-range-microvolts which is a standard name, therefore this name
> must be used.
>
> Fixes: fd9373e41b9ba ("iio: dac: ad5766: add driver support for AD5766")
> Signed-off-by: Mihail Chindris <mihail.chindris@xxxxxxxxxx>
> Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>
Applied this one to the fixes-togreg branch of iio.git and marked it for stable.
Thankfully this is (I think) far enough from the other changes that we
should be able to take the other patches through the togreg tree and have
them all meet up in linux-next / upstream.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ad5766.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5766.c b/drivers/iio/dac/ad5766.c
> index 3104ec32dfac..dafda84fdea3 100644
> --- a/drivers/iio/dac/ad5766.c
> +++ b/drivers/iio/dac/ad5766.c
> @@ -503,13 +503,13 @@ static int ad5766_get_output_range(struct ad5766_state *st)
> int i, ret, min, max, tmp[2];
>
> ret = device_property_read_u32_array(&st->spi->dev,
> - "output-range-voltage",
> + "output-range-microvolts",
> tmp, 2);
> if (ret)
> return ret;
>
> - min = tmp[0] / 1000;
> - max = tmp[1] / 1000;
> + min = tmp[0] / 1000000;
> + max = tmp[1] / 1000000;
> for (i = 0; i < ARRAY_SIZE(ad5766_span_tbl); i++) {
> if (ad5766_span_tbl[i].min != min ||
> ad5766_span_tbl[i].max != max)