Re: [PATCH v7 7/8] clk: qcom: dispcc-sm8250: stop using mmcx regulator

[Dmitry Baryshkov]

On 07/10/2021 18:48, Bjorn Andersson wrote:
> On Sun 29 Aug 08:47 PDT 2021, Dmitry Baryshkov wrote:
>
> > Now as the common qcom clock controller code has been taught about power
> > domains, stop mentioning mmcx supply as a way to power up the clock
> > controller's gdsc.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> Once we merge these, I expect that the boards will start crashing if
> the kernel is booted using an existing DTB?
>
> Is it okay to just merge the first 6 patches in the series now and
> postpone these two until we've had the dts change sitting for a while?

Sure it is.

> Regards,
> Bjorn
>
> > ---
> >   drivers/clk/qcom/dispcc-sm8250.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8250.c
> > index 108dd1249b6a..cf0bb12eb6e1 100644
> > --- a/drivers/clk/qcom/dispcc-sm8250.c
> > +++ b/drivers/clk/qcom/dispcc-sm8250.c
> > @@ -1129,7 +1129,6 @@ static struct gdsc mdss_gdsc = {
> >   	},
> >   	.pwrsts = PWRSTS_OFF_ON,
> >   	.flags = HW_CTRL,
> > -	.supply = "mmcx",
> >   };
> >   
> >   static struct clk_regmap *disp_cc_sm8250_clocks[] = {
> > --
> > 2.33.0


--
With best wishes
Dmitry