Re: [PATCH v8 07/11] x86/tdx: Add HLT support for TDX guest

[Kuppuswamy, Sathyanarayanan]

On 10/6/21 12:17 PM, Josh Poimboeuf wrote:
> I'm having trouble following this last comment, does it mean there's no
> way to return the error back to the #VE handler when this is called in
> #VE context?  Seems like that would be any easy problem to solve by
> shuffling the functions a bit.

Currently tdx_*halt() calls are used in both pv_ops and
tdx_handle_virtualization_exception(). If it is just
tdx_handle_virtualization_exception() then we can just return the error
and let exc_virtualization_exception() handle error using ve_raise_fault().

But in this case, since pv_ops is also involved, instead of defining
two different halt handler functions for pv_ops and
exc_virtualization_exception( we just use WARN_ON to report
the error.


--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer