Re: [PATCH] ocfs2/dlm: Remove redundant assignment of variable ret

[Joseph Qi]

On 10/8/21 7:34 AM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The variable ret is being assigned a value that is never read, it is
> updated later on with a different value. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
> ---
>  fs/ocfs2/dlm/dlmrecovery.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index e24e327524f8..52ad342fec3e 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -2698,7 +2698,6 @@ static int dlm_send_begin_reco_message(struct dlm_ctxt *dlm, u8 dead_node)
>  			continue;
>  		}
>  retry:
> -		ret = -EINVAL;
>  		mlog(0, "attempting to send begin reco msg to %d\n",
>  			  nodenum);
>  		ret = o2net_send_message(DLM_BEGIN_RECO_MSG, dlm->key,
>