Re: [PATCH 0/5] Switchtec Fixes and Improvements

From: Bjorn Helgaas
Date: Fri Oct 08 2021 - 13:05:56 EST


On Fri, Sep 24, 2021 at 11:08:37AM +0000, kelvin.cao@xxxxxxxxxxxxx wrote:
> From: Kelvin Cao <kelvin.cao@xxxxxxxxxxxxx>
>
> Hi,
>
> Please find a bunch of patches for the switchtec driver collected over the
> last few months.

Question: Is there a reason this driver should be in drivers/pci/?

It doesn't use any internal PCI core interfaces, e.g., it doesn't
include drivers/pci/pci.h, and AFAICT it's really just a driver for a
PCI device that happens to be a switch.

I don't really *care* that it's in drivers/pci; I rely on Kurt and
Logan to review changes. The only problem it presents for me is that
I have to write merge commit logs for the changes. You'd think that
would be trivial, but since I don't know much about the driver, it
does end up being work for me.

Bjorn