Re: [PATCH] RDMA: Remove redundant 'flush_workqueue()' calls

From: Leon Romanovsky
Date: Tue Oct 12 2021 - 02:23:29 EST


On Sun, Oct 10, 2021 at 04:08:10PM +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/infiniband/core/sa_query.c | 1 -
> drivers/infiniband/hw/cxgb4/cm.c | 1 -
> drivers/infiniband/hw/cxgb4/device.c | 1 -
> drivers/infiniband/hw/mlx4/alias_GUID.c | 4 +---
> drivers/infiniband/sw/siw/siw_cm.c | 4 +---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 -
> 6 files changed, 2 insertions(+), 10 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>