Re: [patch 16/31] x86/fpu: Replace KVMs homebrewn FPU copy to user

From: Paolo Bonzini
Date: Wed Oct 13 2021 - 01:34:54 EST


On 12/10/21 19:47, Thomas Gleixner wrote:
The memset(guest_xsave, 0, sizeof(struct kvm_xsave)) also is not
reproduced, you can make it unconditional for simplicity; this is not a
fast path.
Duh, I should have mentioned that in the changelog. The buffer is
allocated with kzalloc() soe the memset is redundant, right?

Yes, I always confuse the __user pointers with the temporary ones that are allocated in the callers.

Paolo