Re: [PATCH v4 1/5] KVM: SVM: Get rid of set_ghcb_msr() and *ghcb_msr_bits() functions

From: Sean Christopherson
Date: Wed Oct 13 2021 - 18:08:07 EST


On Wed, Sep 29, 2021, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
>
> Replace the get_ghcb_msr_bits() function with macros and open code the
> GHCB MSR setters with hypercall specific helper macros and functions.
> This will avoid preserving any previous bits in the GHCB-MSR and
> improves code readability.
>
> Also get rid of the set_ghcb_msr() function and open-code it at its
> call-sites for better code readability.
>
> Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

I suspect my SoB got picked up accidentally. If the intent was to attribute some
code snippets via Co-developed-by, feel free to just drop my SoB.