Re: [PATCH] staging: vchiq_arm: Add 36-bit address support

[Dan Carpenter]

On Thu, Oct 14, 2021 at 06:32:30PM -0400, Mwesigwa Guma wrote:
> Cc: Nicolas Saenz Julienne <nsaenz@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Stefan Wahren <stefan.wahren@xxxxxxxx>
> Cc: Ojaswin Mujoo <ojaswin98@xxxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Amarjargal Gundjalam <amarjargal16@xxxxxxxxx>
> Cc: Phil Elwell <phil@xxxxxxxxxxxxxxx>
> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
> Cc: linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx 
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx 
> Cc: linux-staging@xxxxxxxxxxxxxxx 
> Cc: fedora-rpi@xxxxxxxxxxxxxxxx
> Cc: Joel Savitz <jsavitz@xxxxxxxxxx>
> Cc: Chukpozohn Toe <ctoe@xxxxxxxxxx>
> Cc: Clark Williams <clark@xxxxxxxxxx>
> 

Did you intend to put this CC list here?  It goes at the end next to
the Signed-off-by line if so.  I don't feel like it's required except
maybe Phil to show he was Cc'd.

> This is a forward port of Phil Elwell's commit from the Raspberry Pi
> Linux fork described as follows [1]:

Please use the From: header to give authorship credit.

From: Phil Elwell <phil@xxxxxxxxxxxxxxx>

Make that the first line of the email.

> 
>     Conditional on a new compatible string, change the pagelist encoding
>     such that the top 24 bits are the pfn, leaving 8 bits for run length
>     (-1), giving a 36-bit address range.
>     
>     Manage the split between addresses for the VPU and addresses for the
>     40-bit DMA controller with a dedicated DMA device pointer that on non-
>     BCM2711 platforms is the same as the main VCHIQ device. This allows
>     the VCHIQ node to stay in the usual place in the DT.
> 
> This commit enables VCHIQ device access on a Raspberry Pi 4B running the 
> mainline Linux kernel.
> 
> Tested on Fedora Linux running on a Raspberry Pi 4B.
> 
> [1]: https://github.com/raspberrypi/linux/commit/97268fd23eb8d08dc74eac5e3fd697303de26610
> 
> Signed-off-by: Mwesigwa Guma <mguma@xxxxxxxxxx>

regards,
dan carpenter