Re: [PATCH 4/7] staging: r8188eu: remove ODM_AntselStatistics_88C()

[Martin Kaiser]

Thus wrote Michael Straube (straube.linux@xxxxxxxxx):

> Function ODM_AntselStatistics_88C() is not used, remove it.

> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
>  drivers/staging/r8188eu/hal/odm.c     | 21 ---------------------
>  drivers/staging/r8188eu/include/odm.h |  3 ---
>  2 files changed, 24 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
> index 28bd6f36cddd..d3d13164ca8f 100644
> --- a/drivers/staging/r8188eu/hal/odm.c
> +++ b/drivers/staging/r8188eu/hal/odm.c
> @@ -1016,27 +1016,6 @@ void odm_InitHybridAntDiv(struct odm_dm_struct *pDM_Odm)
>  	ODM_AntennaDiversityInit_88E(pDM_Odm);
>  }

> -void ODM_AntselStatistics_88C(struct odm_dm_struct *pDM_Odm, u8 MacId, u32 PWDBAll, bool isCCKrate)
> -{
> -	struct sw_ant_switch *pDM_SWAT_Table = &pDM_Odm->DM_SWAT_Table;
> -
> -	if (pDM_SWAT_Table->antsel == 1) {
> -		if (isCCKrate) {
> -			pDM_SWAT_Table->CCK_Ant1_Cnt[MacId]++;
> -		} else {
> -			pDM_SWAT_Table->OFDM_Ant1_Cnt[MacId]++;
> -			pDM_SWAT_Table->RSSI_Ant1_Sum[MacId] += PWDBAll;
> -		}
> -	} else {
> -		if (isCCKrate) {
> -			pDM_SWAT_Table->CCK_Ant2_Cnt[MacId]++;
> -		} else {
> -			pDM_SWAT_Table->OFDM_Ant2_Cnt[MacId]++;
> -			pDM_SWAT_Table->RSSI_Ant2_Sum[MacId] += PWDBAll;
> -		}
> -	}
> -}
> -

Yet again, that seems to make a bunch of variables unused.
I guess that antsel, CCK_Ant1_Cnt, OFDM_Ant1_Cnt, RSSI_Ant1_Sum and their
Ant2 versions can be removed (haven't tried it yet, though).

I'm really curious to see what's left when we're done with all these
removals...

Best regards,
Martin