Re: [PATCH 0/8] staging: r8188eu: another round of removals

From: Phillip Potter
Date: Sat Oct 16 2021 - 11:35:07 EST


On Sat, Oct 16, 2021 at 01:30:00PM +0200, Martin Kaiser wrote:
> Remove some more dead code and unused definitions.
>
> Martin Kaiser (8):
> staging: r8188eu: remove empty trigger gpio code
> staging: r8188eu: interface type is always usb
> staging: r8188eu: remove two checks that are always false
> staging: r8188eu: remove unused function prototypes
> staging: r8188eu: PHY_SetRFPathSwitch_8188E is not used
> staging: r8188eu: clean up Hal8188EPhyCfg.h
> staging: r8188eu: remove procfs functions
> staging: r8188eu: CurrentWirelessMode is not used
>
> drivers/staging/r8188eu/Makefile | 1 -
> drivers/staging/r8188eu/core/rtw_debug.c | 886 ------------------
> .../staging/r8188eu/hal/HalHWImg8188E_BB.c | 14 +-
> .../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 3 +-
> .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 8 +-
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 38 -
> drivers/staging/r8188eu/hal/odm.c | 3 -
> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 -
> drivers/staging/r8188eu/hal/usb_halinit.c | 8 -
> .../staging/r8188eu/include/Hal8188EPhyCfg.h | 78 --
> drivers/staging/r8188eu/include/hal_intf.h | 1 -
> drivers/staging/r8188eu/include/odm.h | 11 +-
> .../staging/r8188eu/include/rtl8188e_hal.h | 1 -
> drivers/staging/r8188eu/include/rtw_debug.h | 148 ---
> 14 files changed, 6 insertions(+), 1196 deletions(-)
> delete mode 100644 drivers/staging/r8188eu/core/rtw_debug.c
>
> --
> 2.20.1
>

Dear Martin,

Looks good from what I can see, many thanks. Built and tested on my
USB-N10 Nano.

For whole series:
Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>

Regards,
Phil