Re: [PATCH] mm: allow huge kvmalloc() calls if they're accounted to memcg

From: Paolo Bonzini
Date: Sat Oct 16 2021 - 13:53:46 EST


On 16/10/21 17:39, Linus Torvalds wrote:
The big allocation warnings are not about whether we have the memory
or not, or about whether it's accounted or not.
It's about bugs and overflows. Which we've had.

Yes, I understand that...

At least GFP_NOWARN would be somewhat sensible - although still wrong.

... and it also seemed wrong to overload GFP_NOWARN.

It should really be about "I've been careful with growing my
allocations", not about whether accounting or similar should be
disabled. If the allocations really are expected to be that big, and
it's actually valid, just do vmalloc(), which doesn't warn.
Sounds good, and you'll get a pull request for that tomorrow. Then I'll send via Andrew a patch to add __vcalloc, so that the accounting is restored.

Paolo