Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere

From: Greg KH
Date: Mon Oct 18 2021 - 04:26:45 EST


On Mon, Oct 18, 2021 at 05:19:02PM +0900, William Breathitt Gray wrote:
> On Mon, Oct 18, 2021 at 08:06:58AM +0200, Greg KH wrote:
> > On Mon, Oct 18, 2021 at 08:33:34AM +0900, William Breathitt Gray wrote:
> > > On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote:
> > > > In the counter subsystem, we are already using sysfs_emit(), but there
> > > > were a few places where we were still using sprintf() in *_show()
> > > > functions. For consistency and added protections, use sysfs_emit()
> > > > everywhere.
> > > >
> > > > Suggested-by: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> > >
> > > Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> >
> > Thanks, want me to take this directly on top of the previous pull
> > request?
> >
> > greg k-h
>
> Yes, that should be a fine path forward for this patch.

Great! Can you also ack the other patch from David as well?

thanks,

greg k-h