Re: [PATCH] [v2] bcache: hide variable-sized types from uapi header check

[Coly Li]

On 10/18/21 10:39 PM, Arnd Bergmann wrote:
> On Mon, Oct 18, 2021 at 4:20 PM Coly Li <colyli@xxxxxxx> wrote:
> > IMHO, remove bcache related header from uapi check might be better
> > solution. So far only bcache-tools uses this header with its own copy,
> > no application includes the header(s) so far. It makes sense to exclude
> > bcache.h from upai headers check.
> Should we just move it to include/linux/ and out of the uapi headers entirely
> then? It sounds like it's not actually an ABI but just the definition of the
> data layout that is not included by anything from user space.
>
> We are a bit inconsistent here already, e.g. btrfs has all its structures
> in uapi, but ext4 does not.

I am quite open for this idea. It is in uapi directory before I maintain 
bcache. I just though the header fines on-media format should go into 
include/uapi/, but if this is not the restricted rule, it is fine for me 
to move this header to drivers/md/bcache/.

Coly Li