Re: [PATCH] [v2] bcache: hide variable-sized types from uapi header check

From: Christoph Hellwig
Date: Mon Oct 18 2021 - 11:22:32 EST


On Mon, Oct 18, 2021 at 10:42:37PM +0800, Coly Li wrote:
> I am quite open for this idea. It is in uapi directory before I maintain
> bcache. I just though the header fines on-media format should go into
> include/uapi/, but if this is not the restricted rule, it is fine for me to
> move this header to drivers/md/bcache/.

Treating the on-disk definitions as a UAPI doesn't make much sense to
me. I like keeping it in a separate header to make clear what is the
on-disk format and what is just in core, but it should normally live
with the rest of the code.