Re: [PATCH v3 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl

[Sean Christopherson]

On Mon, Oct 18, 2021, Paolo Bonzini wrote:
> On 18/10/21 19:17, Sean Christopherson wrote:
> > 			/*
> > 			 * Report errors due to #GP or SGX_ENCLAVE_ACT, but do
> > 			 * not WARN as userspace can induce said failures by
> > 			 * calling the ioctl concurrently on multiple vEPCs or
> > 			 * while one or more CPUs is running the enclave.  Only
> > 			 * a #PF on EREMOVE indicates a kernel/hardware issue.
> > 			 */
> > 			WARN_ON_ONCE(encls_faulted(ret) &&
> > 				     ENCLS_TRAPNR(ret) == X86_TRAP_PF);
> 
> or != X86_TRAP_GP, just to avoid having a v5? :)

LOL, good point, that's indeed better.