Re: Kconfig issue with LOG_CPU_MAX_BUF_SHIFT + BASE_SMALL

From: Luis Chamberlain
Date: Mon Oct 18 2021 - 16:52:24 EST


On Mon, Oct 18, 2021 at 11:21:22AM +0200, Vegard Nossum wrote:
> The most straightforward fix seems to be change init/Kconfig and
> LOG_CPU_MAX_BUF_SHIFT to say:
>
> default 12 if BASE_SMALL=0
> default 0 if BASE_SMALL!=0

Thanks for reporting! Please feel free to send a patch with a Fixes
annotation.

> In fact, I'm not sure what the point of BASE_SMALL is in the first
> place. Should we get rid of it altogether? (git blame says it's been
> there since the initial commit.)

That's just the inverse of BASE_FULL, if you'd like to remove BASE_SMALL
take it up with the folks with added BASE_FULL, but I have a feeling
that may not be something they are up for.

Luis