RE: [PATCH] rtw89: fix error function parameter

[Pkshih]

> -----Original Message-----
> From: cgel.zte@xxxxxxxxx <cgel.zte@xxxxxxxxx>
> Sent: Tuesday, October 19, 2021 11:53 AM
> To: kvalo@xxxxxxxxxxxxxx
> Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; Pkshih <pkshih@xxxxxxxxxxx>; lv.ruyi@xxxxxxxxxx;
> linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Zeal
> Robot <zealci@xxxxxxxxxx>
> Subject: [PATCH] rtw89: fix error function parameter
> 
> From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> 
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING  possible condition with no effect (if == else)
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>

Thanks for the catch.

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
>  drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -753,11 +753,11 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
>                 if (is_2g)
>                         rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>                                               B_P1_MODE_SEL,
>                                               1, phy_idx);
>  		else
>  			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>  					      B_P1_MODE_SEL,
> -					      1, phy_idx);
> +					      0, phy_idx);
>  		/* SCO compensate FC setting */
>  		sco_comp = rtw8852a_sco_mapping(central_ch);
>  		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1