RE: [PATCH] driver: net: can: disable clock when it is in enable status

From: Li, Meng
Date: Tue Oct 19 2021 - 05:33:39 EST




> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: Tuesday, October 19, 2021 5:23 PM
> To: Li, Meng <Meng.Li@xxxxxxxxxxxxx>
> Cc: wg@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx;
> mailhol.vincent@xxxxxxxxxx; socketcan@xxxxxxxxxxxx;
> ramesh.shanmugasundaram@xxxxxxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] driver: net: can: disable clock when it is in enable status
>
> On 19.10.2021 17:14:16, Meng Li wrote:
> > If disable a clock when it is already in disable status, there will be
> > a warning trace generated. So, it is need to confirm whether what
> > status the clock is in before disable it.
> >
> > Fixes: a23b97e6255b ("can: rcar_can: Move Renesas CAN driver to rcar
> > dir")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Meng Li <Meng.Li@xxxxxxxxxxxxx>
>
> Thanks for your patch. This problem should have been resolved with:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id
> =f7c05c3987dcfde9a4e8c2d533db013fabebca0d
>

Ok!
Thanks for reminding me.

Regards,
Limeng

> regards
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |