Re: [PATCH v1 5/5] drm/bridge: tc358768: Correct BTACNTRL1 programming

[Robert Foss]

On Sun, 3 Oct 2021 at 01:35, Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> TXTAGOCNT and RXTASURECNT bitfields of BTACNTRL1 register are swapped in
> the code, correct them. Driver doesn't implement low power mode for now,
> so this change doesn't make a practical difference yet.
>
> Tested-by: Andreas Westman Dorcsak <hedmoo@xxxxxxxxx> # Asus TF700T
> Tested-by: Maxim Schwalm <maxim.schwalm@xxxxxxxxx> #TF700T
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
>  drivers/gpu/drm/bridge/tc358768.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index cfceba5ef3b8..fd585bf925fe 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -790,7 +790,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge)
>         val = tc358768_ns_to_cnt(val, dsibclk_nsk) - 1;
>         val2 = tc358768_ns_to_cnt(tc358768_to_ns((lptxcnt + 1) * dsibclk_nsk),
>                                   dsibclk_nsk) - 2;
> -       val |= val2 << 16;
> +       val = val << 16 | val2;
>         dev_dbg(priv->dev, "BTACNTRL1: 0x%x\n", val);
>         tc358768_write(priv, TC358768_BTACNTRL1, val);
>

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>