Re: [EXTERNAL] Re: [v3 2/2] ASoC: max98520: add max98520 audio amplifier driver

[Mark Brown]

On Tue, Oct 19, 2021 at 07:57:26AM +0000, George Song wrote:

> > > +	/* L/R mix configuration */
> > > +	regmap_write(max98520->regmap, MAX98520_R2043_PCM_RX_SRC1, 0x2);
> > > +
> > > +	regmap_write(max98520->regmap, MAX98520_R2044_PCM_RX_SRC2, 0x10);
> > 
> > These should be exposed to the user, not hard coded - different systems
> > may need different configurations.
> It`s already exposed for 2043 register which is regarding mono mixer for "DAI Sel Mux"
> It will be exposed for 2044 register which is regarding pcm input channel selection to dapm mixer.

Then leave the values at the defaults and let the user select what's
sensible for their system.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Attachment: signature.asc
Description: PGP signature