Re: [PATCH v3 2/2] firmware: arm_scmi: Add optee transport

From: kernel test robot
Date: Tue Oct 19 2021 - 08:50:12 EST

Hi Etienne,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linux/master soc/for-next rockchip/for-next arm64/for-next/core shawnguo/for-next linus/master v5.15-rc6 next-20211018]
[cannot apply to arm/for-next keystone/next xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Etienne-Carriere/dt-bindings-arm-Add-OP-TEE-transport-for-SCMI/20211018-194259
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r026-20211018 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d245f2e8597bfb52c34810a328d42b990e4af1a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/7dff6aa629cdf70e8001dcc7b565d134c61e6dab
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Etienne-Carriere/dt-bindings-arm-Add-OP-TEE-transport-for-SCMI/20211018-194259
git checkout 7dff6aa629cdf70e8001dcc7b565d134c61e6dab
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/firmware/arm_scmi/optee.c:233:27: error: use of undeclared identifier 'scmi_optee_desc'; did you mean 'scmi_virtio_desc'?
const size_t msg_size = scmi_optee_desc.max_msg_size;
^~~~~~~~~~~~~~~
scmi_virtio_desc
drivers/firmware/arm_scmi/common.h:422:31: note: 'scmi_virtio_desc' declared here
extern const struct scmi_desc scmi_virtio_desc;
^
drivers/firmware/arm_scmi/optee.c:266:26: error: use of undeclared identifier 'scmi_optee_desc'; did you mean 'scmi_virtio_desc'?
const size_t msg_size = scmi_optee_desc.max_msg_size;
^~~~~~~~~~~~~~~
scmi_virtio_desc
drivers/firmware/arm_scmi/common.h:422:31: note: 'scmi_virtio_desc' declared here
extern const struct scmi_desc scmi_virtio_desc;
^
2 errors generated.


vim +233 drivers/firmware/arm_scmi/optee.c

221
222 static int invoke_process_smt_channel(struct optee_channel *channel)
223 {
224 struct tee_ioctl_invoke_arg arg = { };
225 struct tee_param param[2] = { };
226 int ret;
227
228 arg.session = channel->tee_session;
229 param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT;
230 param[0].u.value.a = channel->channel_id;
231
232 if (channel->tee_shm) {
> 233 const size_t msg_size = scmi_optee_desc.max_msg_size;
234
235 param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_INOUT;
236 param[1].u.memref.shm = channel->tee_shm;
237 param[1].u.memref.size = msg_size;
238 arg.num_params = 2;
239 arg.func = PTA_SCMI_CMD_PROCESS_SMT_CHANNEL_MESSAGE;
240 } else {
241 arg.num_params = 1;
242 arg.func = PTA_SCMI_CMD_PROCESS_SMT_CHANNEL;
243 }
244
245 ret = tee_client_invoke_func(optee_private->tee_ctx, &arg, param);
246 if (ret < 0 || arg.ret) {
247 dev_err(optee_private->dev, "Failed on channel %u: %d / %#x\n",
248 channel->channel_id, ret, arg.ret);
249
250 return -EIO;
251 }
252
253 return 0;
254 }
255

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip