Re: [PATCH 7/8] ftrace: Add multi direct modify interface

From: Jiri Olsa
Date: Tue Oct 19 2021 - 10:03:13 EST


On Tue, Oct 19, 2021 at 09:32:16AM -0400, Steven Rostedt wrote:
> On Tue, 19 Oct 2021 15:26:21 +0200
> Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> > > when trying to apply on top of my changes
> >
> > I updated my ftrace/direct branch, it actually still had the previous
> > version.. sorry, perhaps this is the cause of fuzz
>
> I just pushed it (including your patches) here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
>
> ftrace/core
>
>
> This is where I keep my WIP code. It should not be used to base anything
> off of, as I rebase it constantly. But it has the current version I plan on
> testing.
>
> You can make sure the patches in there have your latest version, as you can
> review my patch. I'll update the tags if you give me one.

I'm getting error when compiling:

CC kernel/trace/ftrace.o
kernel/trace/ftrace.c: In function ‘modify_ftrace_direct_multi’:
kernel/trace/ftrace.c:5608:2: error: label ‘out_unlock’ defined but not used [-Werror=unused-label]
5608 | out_unlock:
| ^~~~~~~~~~

looks like out_unlock is nolonger needed, I removed it

jirka