Re: [PATCH] NFSD:fix boolreturn.cocci warning

[Chuck Lever III]

> On Oct 19, 2021, at 12:14 AM, cgel.zte@xxxxxxxxx wrote:
> 
> From: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
> 
> ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function
> 'nfssvc_decode_voidarg' with return type bool
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Changcheng Deng <deng.changcheng@xxxxxxxxxx>

LGTM.


> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 362e819ff06a..80431921e5d7 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
>  */
> bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr)
> {
> -	return 1;
> +	return true;
> }
> 
> /**
> -- 
> 2.25.1
> 

--
Chuck Lever