Re: [PATCH v3 1/3] KVM: emulate: Don't inject #GP when emulating RDMPC if CR0.PE=0

[Wanpeng Li]

On Wed, 20 Oct 2021 at 01:00, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 19/10/21 10:12, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@xxxxxxxxxxx>
> >
> > SDM mentioned that, RDPMC:
> >
> >    IF (((CR4.PCE = 1) or (CPL = 0) or (CR0.PE = 0)) and (ECX indicates a supported counter))
> >        THEN
> >            EAX := counter[31:0];
> >            EDX := ZeroExtend(counter[MSCB:32]);
> >        ELSE (* ECX is not valid or CR4.PCE is 0 and CPL is 1, 2, or 3 and CR0.PE is 1 *)
> >            #GP(0);
> >    FI;
> >
> > Let's add the CR0.PE is 1 checking to rdpmc emulate, though this isn't
> > strictly necessary since it's impossible for CPL to be >0 if CR0.PE=0.
>
> Why not just add a comment then instead?

Will do.

    Wanpeng