Re: [PATCH v3 10/13] net: phy: add qca8081 config_init

[Jie Luo]

On 10/19/2021 5:47 AM, Andrew Lunn wrote:
> > +static int qca808x_phy_fast_retrain_config(struct phy_device *phydev)
> > +{
> > +	int ret;
> > +
> > +	ret = phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_CTRL,
> > +			MDIO_AN_10GBT_CTRL_ADV2_5G |
> > +			MDIO_AN_10GBT_CTRL_ADVFSRT2_5G |
> > +			MDIO_AN_10GBT_CTRL_ADVLPTIMING);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_FSRT_CSR,
> > +			MDIO_PMA_10GBR_FSRT_ENABLE);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_CTRL2, MDIO_AN_THP_BP2_5GT);
> > +	if (ret)
> > +		return ret;
> Could that be made generic and put into phy-c45.c? Is there anything
> specific to your PHY here?
>
> 	 Andrew

Hi Andrew,

Thanks for the comments, there is no specific to the PHY, will put it 
into phy-c45.c in the next patch set.