Re: [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string

[Geert Uytterhoeven]

Hi Miguel,

On Tue, Oct 19, 2021 at 11:09 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Tue, Oct 19, 2021 at 10:50 PM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> >
> > Unrelated to this patch (and no need to change it), but we could
> > remove the conditional guarding the devm_kfree below to match this
> > one.
>
> Yeah, you did it when moving the code later on -- I guess we could
> have done it before too, to match, like the sysfs_emit change does it
> before, but it is not that important.

As this patch fixes a DoS that can be triggered from userspace,
I wanted it to be a fix as small and concise as possible.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds