RE: [PATCH v2 03/21] ACPI: CPPC: Check online CPUs for determining _CPC is valid

[Huang, Ray]

[AMD Official Use Only]

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Sent: Wednesday, October 20, 2021 12:53 AM
> To: Huang, Ray <Ray.Huang@xxxxxxx>
> Cc: Rafael J . Wysocki <rafael.j.wysocki@xxxxxxxxx>; Viresh Kumar
> <viresh.kumar@xxxxxxxxxx>; Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>;
> Borislav Petkov <bp@xxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Ingo
> Molnar <mingo@xxxxxxxxxx>; Linux PM <linux-pm@xxxxxxxxxxxxxxx>;
> Sharma, Deepak <Deepak.Sharma@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; Fontenot, Nathan
> <Nathan.Fontenot@xxxxxxx>; Su, Jinzhou (Joe) <Jinzhou.Su@xxxxxxx>;
> Du, Xiaojian <Xiaojian.Du@xxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; the arch/x86 maintainers <x86@xxxxxxxxxx>
> Subject: Re: [PATCH v2 03/21] ACPI: CPPC: Check online CPUs for
> determining _CPC is valid
> 
> On Sun, Sep 26, 2021 at 11:06 AM Huang Rui <ray.huang@xxxxxxx> wrote:
> >
> > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > As this is a static check, it should be based upon what is currently
> > present on the system. This makes probeing more deterministic.
> >
> > While local APIC flags field (lapic_flags) of cpu core in MADT table
> > is 0, then the cpu core won't be enabled. In this case, _CPC won't be
> > found in this core, and return back to _CPC invalid with walking
> > through possible cpus (include disable cpus). This is not expected, so
> > switch to check online CPUs instead.
> >
> > Reported-by: Jinzhou Su <Jinzhou.Su@xxxxxxx>
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> > Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
> > ---
> >  drivers/acpi/cppc_acpi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index
> > a4d4eebba1da..2efe2ba97d96 100644
> > --- a/drivers/acpi/cppc_acpi.c
> > +++ b/drivers/acpi/cppc_acpi.c
> > @@ -411,7 +411,7 @@ bool acpi_cpc_valid(void)
> >         struct cpc_desc *cpc_ptr;
> >         int cpu;
> >
> > -       for_each_possible_cpu(cpu) {
> > +       for_each_online_cpu(cpu) {
> 
> Shouldn't this be for_each_present_cpu()?  In case a CPU is present, but not
> online when cppc_cpufreq is loaded?
> 

OK, got it, thanks! Will update it in V3.

Thanks,
Ray