Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const.

From: Arnaldo Carvalho de Melo
Date: Wed Oct 20 2021 - 09:24:41 EST


Em Tue, Oct 19, 2021 at 12:19:24PM +0100, John Garry escreveu:
> On 15/10/2021 18:21, Ian Rogers wrote:

> - bouncing Changbin Du <changbin.du@xxxxxxxxx> and Jin Yao
> <yao.jin@xxxxxxxxxxxxxxx>

> > Make lookup nature of data structures clearer through their type. Reduce
> > scope of architecture specific pmu_event tables by making them static.

> > Suggested-by: John Garry<john.garry@xxxxxxxxxx>
> > Acked-by: Andi Kleen<ak@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ian Rogers<irogers@xxxxxxxxxx>

> Reviewed-by: John Garry <john.garry@xxxxxxxxxx>

> BTW, We seem to be using > 80 char per line now. Well in metricgroup.h
> anyway, from a brief check. I know checkpatch.pl is ok with this now, but
> some maintainers aren't. Just saying.

I don't have a problem with that:

[acme@quaco ~]$ echo $COLUMNS
273
[acme@quaco ~]$

:-)

- Arnaldo