Re: [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression

From: Steven Rostedt
Date: Wed Oct 20 2021 - 10:28:13 EST


On Tue, 19 Oct 2021 18:31:40 -0700
Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:

> + minus_op = strrchr(str, '-');
> + if (minus_op) {
> + /* Unfortunately, the modifier ".sym-offset" can confuse things. */
> + if (minus_op - str >= 4 && !strncmp(minus_op - 4, ".sym-offset", 11))
> + goto out;
>

I was thinking about this, and perhaps we can add this later, but we could
just replace all ".sym-offset" with ".symXoffset" after receiving it from
the user. Then it won't be an issue during prasing.

-- Steve