Re: [PATCH 0/2] perf jevents: Enable build warnings

From: John Garry
Date: Wed Oct 20 2021 - 10:41:11 EST


On 20/10/2021 15:31, Arnaldo Carvalho de Melo wrote:
Em Sat, Oct 16, 2021 at 12:48:25AM +0800, John Garry escreveu:
Currently jevents builds without any complier warning flags enabled. So
use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS. I am not
100% confident that this is the best way, but sending out for review.

Baseline is be8ecc57f180 (HEAD, acme/perf/core) perf srcline: Use
long-running addr2line per DSO

Thanks, applied.


Hi Arnaldo,

I was going to send a v2, with changes according to James Clark's review - that was to add -Wall & -Werror, but they caused a problem on your perf/core branch as they triggered the warn fixed in commit b94729919db2.

I suppose the best thing now is to send a patch on top once perf/core contains that commit. Let me know otherwise.

Thanks