Re: [block] 52b85909f8: ndctl.test-libndctl.fail

From: Oliver Sang
Date: Wed Oct 20 2021 - 10:49:24 EST


Hi Christoph Hellwig,

On Wed, Sep 01, 2021 at 01:34:24PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 31, 2021 at 10:50:36PM +0800, kernel test robot wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed the following commit (built with gcc-9):
> >
> > commit: 52b85909f85d06efa69aaf4210e72467f1f58d2b ("block: fold register_disk into device_add_disk")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> Can someone help to decode the output? I'm a little lost in debug output
> from libkmod but can't really find anything substancial that looks wrong.

sorry for late, we retested on this commit and its parent,
also we noticed a fix commit:
commit d55174cccac2e4c2a58ff68b6b573fc0836f73bd (nvdimm/libnvdimm-fixes)
Author: Christoph Hellwig <hch@xxxxxx>
Date: Wed Sep 22 19:34:29 2021 +0200

nvdimm/pmem: fix creating the dax group

The recent block layer refactoring broke the way how the pmem driver
abused device_add_disk. Fix this by properly passing the attribute groups
to device_add_disk.

Fixes: 52b85909f85d ("block: fold register_disk into device_add_disk")


rerun on all these 3 commits, we now confirmed the ndctl.test-libndctl.fail
can be reproduced on all of them.

sorry for inconvenience.