Re: [PATCH V2 2/4] dt-bindings: mfd: pm8008: Add pm8008 regulator node

[skakit]

On 2021-10-05 23:40, Stephen Boyd wrote:
> Quoting Satya Priya (2021-09-30 21:00:57)
> > Add pm8008-regulator node and example.
> >
> > Signed-off-by: Satya Priya <skakit@xxxxxxxxxxxxxx>
> > ---
> > Changes in V2:
> >  - As per Rob's comments changed "pm8008[a-z]?-regulator" to
> >    "^pm8008[a-z]?-regulators".
> >
> >  .../devicetree/bindings/mfd/qcom,pm8008.yaml       | 24 
> > ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml 
> > b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> > index ec3138c..0c9665e 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> > @@ -45,6 +45,10 @@ properties:
> >      const: 0
> >
> >  patternProperties:
> > +  "^pm8008[a-z]?-regulators$":
>
> Please just call it 'regulators'
>
> > +    type: object
> > +    $ref: "../regulator/qcom,pm8008-regulator.yaml#"
> > +
> >    "^gpio@[0-9a-f]+$":
> >      type: object
> >
> > @@ -122,6 +126,26 @@ examples:
> >            interrupt-controller;
> >            #interrupt-cells = <2>;
> >          };
> > +
> > +        pm8008-regulators {
>
> Please just call it 'regulators'

Okay

> > +          compatible = "qcom,pm8008-regulator";
> > +          #address-cells = <1>;
> > +          #size-cells = <0>;
> > +
> > +          vdd_l1_l2-supply = <&vreg_s8b_1p2>;
> > +          vdd_l3_l4-supply = <&vreg_s1b_1p8>;
> > +          vdd_l5-supply = <&vreg_bob>;
> > +          vdd_l6-supply = <&vreg_bob>;
> > +          vdd_l7-supply = <&vreg_bob>;
> > +
> > +          pm8008_l1: regulator@4000 {
> > +            reg = <0x4000>;
> > +            regulator-name = "pm8008_l1";
> > +            regulator-min-microvolt = <950000>;
> > +            regulator-max-microvolt = <1300000>;
> > +            qcom,min-dropout-voltage = <96000>;
> > +          };
> > +        };