Re: [PATCH linux-next] net/core: Remove unused assignment operations and variable
From: Simon Horman
Date: Thu Oct 21 2021 - 06:44:23 EST
On Thu, Oct 21, 2021 at 06:40:20AM +0000, luo penghao wrote:
I think the bracketed part of the subject of your emails should be:
[PATCH v2 net-next]
* IIRC this is v2 of the patch
* The patch is targeted at the net-next tree
> Although if_info_size is assigned, it has not been used. And the variable
> should also be deleted.
>
> The clang_analyzer complains as follows:
>
> net/core/rtnetlink.c:3806: warning:
>
> Although the value stored to 'if_info_size' is used in the enclosing
> expression, the value is never actually read from 'if_info_size'.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: luo penghao <luo.penghao@xxxxxxxxxx>
The above not withstanding, this patch looks correct to me.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>