Re: [PATCH 0/2] nbd: fix sanity check for first_minor

[yukuai (C)]

On 2021/10/21 20:35, Pavel Skripkin wrote:
> On 10/21/21 15:29, Yu Kuai wrote:
> > Yu Kuai (2):
> >    nbd: fix max value for 'first_minor'
> >    nbd: fix possible overflow for 'first_minor' in nbd_dev_add()
> >
> >   drivers/block/nbd.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
>
> Hi, Yu!
>
> Thank you for the fix, but this wrong check should be just removed, 
> since root case of wrong sysfs file creation was fixed, as Christoph 
> said [1]

Hi, Pavel

Thanks for your response, with the root cause fixed, patch 1 is not
needed anymore. However, the overflow case in patch 2 is still
possible.

Does anyone plan to remove the checking?

Thanks,
Kuai
> [1] https://lore.kernel.org/lkml/20211011073556.GA10735@xxxxxx/
>
>
>
> With regards,
> Pavel Skripkin
> .