Re: [PATCH v4 1/4] perf bench futex: Call the futex syscall from a function
From: Arnaldo Carvalho de Melo
Date: Thu Oct 21 2021 - 09:25:58 EST
Em Thu, Oct 21, 2021 at 08:39:17AM +1000, Alistair Francis escreveu:
> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> In preparation for a more complex futex() function let's convert the
> current macro into two functions. We need two functions to avoid
> compiler failures as the macro is overloaded.
>
> This will allow us to include pre-processor conditionals in the futex
> syscall functions.
>
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> Acked-by: Davidlohr Bueso <dbueso@xxxxxxx>
> ---
> tools/perf/bench/futex.h | 43 ++++++++++++++++++++++++----------------
> 1 file changed, 26 insertions(+), 17 deletions(-)
Right after applying this one:
In file included from bench/futex-hash.c:29:
bench/futex.h: In function ‘futex_syscall’:
bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
| ^~~~
| s32
bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
| ~~~~~~~~~~~~~~~~~^~~~~~~
bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
53 | }
| ^
cc1: all warnings being treated as errors
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-hash.o] Error 1
make[4]: *** Waiting for unfinished jobs....
In file included from bench/futex-wake-parallel.c:31:
bench/futex.h: In function ‘futex_syscall’:
bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
| ^~~~
| s32
bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
| ~~~~~~~~~~~~~~~~~^~~~~~~
bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
53 | }
| ^
cc1: all warnings being treated as errors
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-wake-parallel.o] Error 1
In file included from bench/futex-requeue.c:26:
bench/futex.h: In function ‘futex_syscall’:
bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
| ^~~~
| s32
bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
| ~~~~~~~~~~~~~~~~~^~~~~~~
bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
53 | }
| ^
cc1: all warnings being treated as errors
In file included from bench/futex-lock-pi.c:19:
bench/futex.h: In function ‘futex_syscall’:
bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
| ^~~~
| s32
bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
| ~~~~~~~~~~~~~~~~~^~~~~~~
bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
53 | }
| ^
cc1: all warnings being treated as errors
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-requeue.o] Error 1
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-lock-pi.o] Error 1
In file included from bench/futex-wake.c:25:
bench/futex.h: In function ‘futex_syscall’:
bench/futex.h:52:61: error: ‘ts32’ undeclared (first use in this function); did you mean ‘s32’?
52 | return syscall(SYS_futex, uaddr, op | opflags, val, ts32, uaddr2, val3);
| ^~~~
| s32
bench/futex.h:52:61: note: each undeclared identifier is reported only once for each function it appears in
bench/futex.h:49:82: error: unused parameter ‘timeout’ [-Werror=unused-parameter]
49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, struct timespec *timeout,
| ~~~~~~~~~~~~~~~~~^~~~~~~
bench/futex.h:53:1: error: control reaches end of non-void function [-Werror=return-type]
53 | }
| ^
cc1: all warnings being treated as errors
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/bench/futex-wake.o] Error 1
make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:139: bench] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile.perf:660: /tmp/build/perf/perf-in.o] Error 2
make[1]: *** [Makefile.perf:240: sub-make] Error 2
make: *** [Makefile:113: install-bin] Error 2
make: Leaving directory '/var/home/acme/git/perf/tools/perf'
Performance counter stats for 'make -k BUILD_BPF_SKEL=1 CORESIGHT=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin':
2,467.00 msec task-clock:u # 1.263 CPUs utilized
2,457.82 msec cpu-clock:u # 1.259 CPUs utilized
1.952573032 seconds time elapsed
1.444401000 seconds user
1.111434000 seconds sys
⬢[acme@toolbox perf]$