Re: [PATCH v2 1/2] percpu_ref: percpu_ref_tryget_live() version holding RCU

[Pavel Begunkov]

On 10/21/21 15:01, Dennis Zhou wrote:
> Hello,
>
> On Thu, Oct 21, 2021 at 02:30:51PM +0100, Pavel Begunkov wrote:
> > Add percpu_ref_tryget_live_rcu(), which is a version of
> > percpu_ref_tryget_live() but the user is responsible for enclosing it in
> > a RCU read lock section.
> >
> > Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
> > ---
> >   include/linux/percpu-refcount.h | 33 +++++++++++++++++++++++----------
> >   1 file changed, 23 insertions(+), 10 deletions(-)
[...]
> > +
> >   /**
> >    * percpu_ref_tryget_live - try to increment a live percpu refcount
> >    * @ref: percpu_ref to try-get
>
> Nit: it's dumb convention at this point, but do you mind copying this
> guy up. I like consistency.

Looks Jens already took it. If you still want it moved, do you mind
it in a separate patch?

And I'm not sure I follow where you want it to be, currently it's
right before percpu_ref_tryget_live, which uses it.

--
Pavel Begunkov