Re: [PATCH 1/4] hugetlb_cgroup: Remove unused hugetlb_cgroup_from_counter macro

From: Mike Kravetz
Date: Fri Oct 22 2021 - 16:17:15 EST


On 10/20/21 11:31 PM, Baolin Wang wrote:
> Since commit 726b7bbe ("hugetlb_cgroup: fix illegal access to memory"),
> the hugetlb_cgroup_from_counter() macro is not used any more, remove it.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> ---
> mm/hugetlb_cgroup.c | 3 ---
> 1 file changed, 3 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
--
Mike Kravetz

>
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index 5383023..79d9353 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -27,9 +27,6 @@
> #define MEMFILE_IDX(val) (((val) >> 16) & 0xffff)
> #define MEMFILE_ATTR(val) ((val) & 0xffff)
>
> -#define hugetlb_cgroup_from_counter(counter, idx) \
> - container_of(counter, struct hugetlb_cgroup, hugepage[idx])
> -
> static struct hugetlb_cgroup *root_h_cgroup __read_mostly;
>
> static inline struct page_counter *
>