Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up

From: Krzysztof Wilczyński
Date: Sat Oct 23 2021 - 05:54:24 EST


Hi,

[...]
> > > > > - default:
> > > > > - break;
> > >
> > > While you're at it, this "default: break;" thing is pointless.
> > > Normally it's better to just *move* something without changing it at
> > > all, but this is such a simple thing I think you could drop this at
> > > the same time as the move.
> > >
> > [Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks.
> [Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6QP.
> So I just don't drop them in v3 patch-set.

I hope you don't mind me asking, but how is an empty default case in the
switch statement helping IMX6Q and IMX6QP? What does it achieve for these
two controllers specifically?

Krzysztof