Re: [PATCHSET v2 0/2] tools/nolibc: Fix startup code bug and small improvement

From: Willy Tarreau
Date: Sun Oct 24 2021 - 07:42:39 EST


On Sun, Oct 24, 2021 at 09:11:30AM +0700, Ammar Faizi wrote:
> Hi Willy,
> This is a patchset v2, there are 2 patches in this series.
>
> [PATCH 1/2] is a bug fix. Thanks to Peter who reported the bug, fixed
> in [PATCH 1/2] by me.
>
> [PATCH 2/2] is just a small improvement to minimize code size, no
> functional changes.
>
> Detailed explanation in the commit message.
> Please review!

Many thanks Ammar, both look good, I've queued them and am now reviewing
the ABI and code for other archs in case I did the same mistake for the
alignment at other places (i386 comes to mind).

I'll also have a look at the exit calls your mentioned.

Thanks!
Willy