Re: [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field

From: Valentin Schneider
Date: Sun Oct 24 2021 - 11:50:53 EST


On 23/10/21 10:10, Marc Zyngier wrote:
> On Fri, 22 Oct 2021 11:33:05 +0100,
> Valentin Schneider <valentin.schneider@xxxxxxx> wrote:
>> -#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
>> -#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
>> +#define RDISTS_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0)
>> +#define RDISTS_FLAGS_RD_TABLES_PREALLOCATED (1 << 1)
>> +
>> +#define RDIST_FLAGS_LPI_ENABLED BIT(0)
>
> Just to reduce the churn and for me not to misread things (because
> RDIST/RDISTS is pretty confusing), how about leaving the original
> flags as is, and name the per-RD ones like:
>
> #define RD_LOCAL_LPI_ENABLED BIT(0)
>
> ?
>
> Or something else that'd be adequately different from the original
> flags?
>

Aye, sounds like the right thing to do!