fs/jffs2/xattr.c:887:1: warning: the frame size of 1040 bytes is larger than 1024 bytes

From: kernel test robot
Date: Sun Oct 24 2021 - 13:38:51 EST

Next message:
Previous
Messages

tree: config: powerpc64-randconfi compiler: powerpc64-linux-gcc reproduce (this is a W=1 build):
wget # If you fix the issue, Reported-by: kernel
All warnings (new
fs/jffs2/xattr.c: fs/jffs2/xattr.c:1247:79: 1247 | | fs/jffs2/xattr.c:1222:34: 1222 | | fs/jffs2/xattr.c: fs/jffs2/xattr.c:1281:86: 1281 | | fs/jffs2/xattr.c:1258:34: 1258 | | fs/jffs2/xattr.c: >> fs/jffs2/xattr.c:887:1: 887 | }
| ^

vim +887 fs/jffs2/xattr.c

aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8f2b6f49c656dd KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8f2b6f49c656dd KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 27c72b040c0be8 David 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 2c887e2359f6e7 KaiGai Kohei 8f2b6f49c656dd KaiGai Kohei 8f2b6f49c656dd KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 2c887e2359f6e7 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei c9f700f840bd48 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei c9f700f840bd48 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei 8a13695cbe4e83 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei aa98d7cf59b5b0 KaiGai Kohei
:::::: The code at :::::: aa98d7cf59b5b0764d35
:::::: TO: KaiGai :::::: CC: KaiGai
---
0-DAY CI Kernel Test Attachment: Description: application/gzip Christophe JAILLET: "[PATCH] dma-mapping: Use 'bitmap_zalloc()' when applicable" message: Christophe JAILLET: "Re: [PATCH 2/2] RDMA/rxe: Use 'bitmap_zalloc()' when applicable" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
348961d3a3ba42065e0cf
4df0d7638536305205d20 ubsan: enable for all*config builds
g-r013-20211019 (attached as .config)
(GCC) 11.2.0
href="https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d0a3ac549f389c1511a4df0d7638536305205d20">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d0a3ac549f389c1511a4df0d7638536305205d20
rel="nofollow" href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
--no-tags linus master
d0a3ac549f389c1511a4df0d7638536305205d20
attached .config to linux build tree
COMPILER=gcc-11.2.0 make.cross ARCH=powerpc
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
ones prefixed by >>):
In function 'jffs2_garbage_collect_xattr_datum':
warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
xd->xid, xd->version, old_ofs, ref_offset(xd->node));
^
warning: variable 'old_ofs' set but not used [-Wunused-but-set-variable]
uint32_t totlen, length, old_ofs;
^~~~~~~
In function 'jffs2_garbage_collect_xattr_ref':
warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
ref->ic->ino, ref->xd->xid, old_ofs, ref_offset(ref->node));
^
warning: variable 'old_ofs' set but not used [-Wunused-but-set-variable]
uint32_t totlen, length, old_ofs;
^~~~~~~
In function 'jffs2_build_xattr_subsystem':
warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
2006-05-13 773
2006-06-11 774 #define XREF_TMPHASH_SIZE (128)
2006-05-13 775 void jffs2_build_xattr_subsystem(struct jffs2_sb_info *c)
2006-05-13 776 {
2006-05-13 777 struct jffs2_xattr_ref *ref, *_ref;
2006-06-11 778 struct jffs2_xattr_ref *xref_tmphash[XREF_TMPHASH_SIZE];
2006-05-13 779 struct jffs2_xattr_datum *xd, *_xd;
2006-05-13 780 struct jffs2_inode_cache *ic;
2006-06-11 781 struct jffs2_raw_node_ref *raw;
2006-05-13 782 int i, xdatum_count = 0, xdatum_unchecked_count = 0, xref_count = 0;
2006-06-24 783 int xdatum_orphan_count = 0, xref_orphan_count = 0, xref_dead_count = 0;
2006-05-13 784
2006-05-13 785 BUG_ON(!(c->flags & JFFS2_SB_FLAG_BUILDING));
2006-05-13 786
2006-06-24 787 /* Phase.1 : Merge same xref */
2006-06-11 788 for (i=0; i < XREF_TMPHASH_SIZE; i++)
2006-06-11 789 xref_tmphash[i] = NULL;
2006-05-13 790 for (ref=c->xref_temp; ref; ref=_ref) {
2006-06-11 791 struct jffs2_xattr_ref *tmp;
2006-06-11 792
2006-05-13 793 _ref = ref->next;
2006-05-13 794 if (ref_flags(ref->node) != REF_PRISTINE) {
2006-05-13 795 if (verify_xattr_ref(c, ref)) {
2006-06-11 796 BUG_ON(ref->node->next_in_ino != (void *)ref);
2006-06-11 797 ref->node->next_in_ino = NULL;
2006-06-11 798 jffs2_mark_node_obsolete(c, ref->node);
2006-05-13 799 jffs2_free_xattr_ref(ref);
2006-05-13 800 continue;
2006-05-13 801 }
2006-05-13 802 }
2006-06-11 803
2006-06-11 804 i = (ref->ino ^ ref->xid) % XREF_TMPHASH_SIZE;
2006-06-11 805 for (tmp=xref_tmphash[i]; tmp; tmp=tmp->next) {
2006-06-11 806 if (tmp->ino == ref->ino && tmp->xid == ref->xid)
2006-06-11 807 break;
2006-06-11 808 }
2006-06-11 809 if (tmp) {
2006-06-11 810 raw = ref->node;
2006-06-11 811 if (ref->xseqno > tmp->xseqno) {
2006-06-11 812 tmp->xseqno = ref->xseqno;
2006-06-11 813 raw->next_in_ino = tmp->node;
2006-06-11 814 tmp->node = raw;
2006-06-11 815 } else {
2006-06-11 816 raw->next_in_ino = tmp->node->next_in_ino;
2006-06-11 817 tmp->node->next_in_ino = raw;
2006-06-11 818 }
2006-06-11 819 jffs2_free_xattr_ref(ref);
2006-06-11 820 continue;
2006-06-11 821 } else {
2006-06-11 822 ref->next = xref_tmphash[i];
2006-06-11 823 xref_tmphash[i] = ref;
2006-06-11 824 }
2006-06-11 825 }
2006-06-11 826 c->xref_temp = NULL;
2006-06-11 827
2006-06-24 828 /* Phase.2 : Bind xref with inode_cache and xattr_datum */
2006-06-11 829 for (i=0; i < XREF_TMPHASH_SIZE; i++) {
2006-06-11 830 for (ref=xref_tmphash[i]; ref; ref=_ref) {
2006-06-24 831 xref_count++;
2006-06-11 832 _ref = ref->next;
2006-06-11 833 if (is_xattr_ref_dead(ref)) {
2006-06-11 834 ref->next = c->xref_dead_list;
2006-06-11 835 c->xref_dead_list = ref;
2006-06-24 836 xref_dead_count++;
2006-06-11 837 continue;
2006-06-11 838 }
2006-05-13 839 /* At this point, ref->xid and ref->ino contain XID and inode number.
2006-05-13 840 ref->xd and ref->ic are not valid yet. */
2006-05-13 841 xd = jffs2_find_xattr_datum(c, ref->xid);
2006-05-13 842 ic = jffs2_get_ino_cache(c, ref->ino);
Woodhouse 2008-05-01 843 if (!xd || !ic || !ic->pino_nlink) {
2006-06-24 844 dbg_xattr("xref(ino=%u, xid=%u, xseqno=%u) is orphan.\n",
2006-06-11 845 ref->ino, ref->xid, ref->xseqno);
2006-06-24 846 ref->xseqno |= XREF_DELETE_MARKER;
2006-06-11 847 ref->next = c->xref_dead_list;
2006-06-11 848 c->xref_dead_list = ref;
2006-06-24 849 xref_orphan_count++;
2006-05-13 850 continue;
2006-05-13 851 }
2006-05-13 852 ref->xd = xd;
2006-05-13 853 ref->ic = ic;
2006-06-24 854 atomic_inc(&xd->refcnt);
2006-05-13 855 ref->next = ic->xref;
2006-05-13 856 ic->xref = ref;
2006-05-13 857 }
2006-06-11 858 }
2006-05-13 859
2006-06-24 860 /* Phase.3 : Link unchecked xdatum to xattr_unchecked list */
2006-05-13 861 for (i=0; i < XATTRINDEX_HASHSIZE; i++) {
2006-05-13 862 list_for_each_entry_safe(xd, _xd, &c->xattrindex[i], xindex) {
2006-06-24 863 xdatum_count++;
2006-05-13 864 list_del_init(&xd->xindex);
2006-06-24 865 if (!atomic_read(&xd->refcnt)) {
2006-06-24 866 dbg_xattr("xdatum(xid=%u, version=%u) is orphan.\n",
2006-06-11 867 xd->xid, xd->version);
2006-06-24 868 xd->flags |= JFFS2_XFLAGS_DEAD;
2006-06-11 869 list_add(&xd->xindex, &c->xattr_unchecked);
2006-06-24 870 xdatum_orphan_count++;
2006-05-13 871 continue;
2006-05-13 872 }
2006-06-11 873 if (is_xattr_datum_unchecked(c, xd)) {
2006-06-11 874 dbg_xattr("unchecked xdatum(xid=%u, version=%u)\n",
2006-06-11 875 xd->xid, xd->version);
2006-05-13 876 list_add(&xd->xindex, &c->xattr_unchecked);
2006-05-13 877 xdatum_unchecked_count++;
2006-05-13 878 }
2006-05-13 879 }
2006-05-13 880 }
2006-05-13 881 /* build complete */
2006-06-24 882 JFFS2_NOTICE("complete building xattr subsystem, %u of xdatum"
2006-06-24 883 " (%u unchecked, %u orphan) and "
2006-06-24 884 "%u of xref (%u dead, %u orphan) found.\n",
2006-06-24 885 xdatum_count, xdatum_unchecked_count, xdatum_orphan_count,
2006-06-24 886 xref_count, xref_dead_count, xref_orphan_count);
2006-05-13 @887 }
2006-05-13 888
line 887 was first introduced by commit
02662053489585faf2fe [JFFS2][XATTR] XATTR support on JFFS2 (version. 5)
Kohei <kaigai@xxxxxxxxxxxxx>
Kohei <kaigai@xxxxxxxxxxxxx>
Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Christophe JAILLET: "[PATCH] dma-mapping: Use 'bitmap_zalloc()' when applicable"
Previous message: Christophe JAILLET: "Re: [PATCH 2/2] RDMA/rxe: Use 'bitmap_zalloc()' when applicable"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]