Re: [PATCH v2][next] sysctl: Avoid open coded arithmetic in memory allocator functions
From: Gustavo A. R. Silva
Date: Sun Oct 24 2021 - 14:49:43 EST
On Sun, Oct 24, 2021 at 06:55:13PM +0100, Matthew Wilcox wrote:
> On Sun, Oct 24, 2021 at 11:13:28AM +0200, Len Baker wrote:
>
> I think it's better for code to be understandable. Your patch makes
> the code less readable in the name of "security", which is a poor
> justification.
I agree with Matthew. Those functions seem to be a bit too much, for
now.
Let's keep it simple and start by replacing the open-coded instances
when possible, first. Then we can dig much deeper depending on each
particular case, taking into consideration readability, which is
certainly important.
Thanks
--
Gustavo