Re: [PATCH 1/2] crypto: qce: Add 'sm8150-qce' compatible string check

[Bjorn Andersson]

On Sun 24 Oct 12:59 CDT 2021, Bhupesh Sharma wrote:

> Hi Bjorn,
> 
> On Sun, 24 Oct 2021 at 22:48, Bjorn Andersson
> <bjorn.andersson@xxxxxxxxxx> wrote:
> >
> > On Wed 13 Oct 11:58 CDT 2021, Bhupesh Sharma wrote:
> >
> > > Add 'sm8150-qce' compatible string check in qce crypto
> > > driver as we add support for sm8150 crypto device in the
> > > device-tree in the subsequent patch.
> > >
> > > Cc: Thara Gopinath <thara.gopinath@xxxxxxxxxx>
> > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> > > ---
> > >  drivers/crypto/qce/core.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
> > > index 4c55eceb4e7f..ecbe9f7c6c0a 100644
> > > --- a/drivers/crypto/qce/core.c
> > > +++ b/drivers/crypto/qce/core.c
> > > @@ -306,6 +306,7 @@ static int qce_crypto_remove(struct platform_device *pdev)
> > >  static const struct of_device_id qce_crypto_of_match[] = {
> > >       { .compatible = "qcom,ipq6018-qce", },
> > >       { .compatible = "qcom,sdm845-qce", },
> > > +     { .compatible = "qcom,sm8150-qce", },
> > >       { .compatible = "qcom,sm8250-qce", },
> >
> > When I look at linux-next I see qce_crypto_of_match defined as:
> >
> > static const struct of_device_id qce_crypto_of_match[] = {
> >         { .compatible = "qcom,crypto-v5.1", },
> >         { .compatible = "qcom,crypto-v5.4", },
> >         {}
> > };
> >
> > Can you please help me understand what I'm doing wrong?
> 
> Oh, you have missed [PATCH 15/20] from the sm8250 qce crypto addition
> series (see [1])
> 
> This series is dependent on the sm8250 qce enablement series, as I
> noted in the cover letter (see [2]).
> 

Ah, now I see. Thanks for the pointer!

> However, Thara and Vladimir pointed out backward compatibility issues
> with PATCH 15/20 of the first series. So I will send a v5 to fix the
> same along with other issues pointed in the v4.
> 
> Sorry for any confusion caused.
> 

No worries. Could you include these two patches in v5 of the other
series, to clarify the dependency?

Thanks,
Bjorn

> [1]. https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@xxxxxxxxxx/T/#m566546d32d8da7ee94822dfba625e98fd3496d17
> [2]. https://www.spinics.net/lists/linux-arm-msm/msg96053.html
> 
> Regards,
> Bhupesh