Re: [PATCH] scsi: ufs: clean up the Kconfig file

From: Randy Dunlap
Date: Sun Oct 24 2021 - 19:36:01 EST


On 10/24/21 2:29 PM, Bart Van Assche wrote:
On 10/23/21 23:43, Randy Dunlap wrote:
@@ -39,7 +38,7 @@ config SCSI_UFSHCD
      select DEVFREQ_GOV_SIMPLE_ONDEMAND
      select NLS
      help
-      This selects the support for UFS devices in Linux, say Y and make
+      This selects the support for UFS devices in Linux. Say Y and make

How about changing "This selects the support for UFS devices in Linux"
into "Enables support for UFS devices"? "the" should be left out from a
grammatical point of view and "in Linux" is redundant.

OK, done (locally).

        sure that you know the name of your UFS host adapter (the card
        inside your computer that "speaks" the UFS protocol, also
        called UFS Host Controller), because you will be asked for it.
@@ -51,7 +50,7 @@ config SCSI_UFSHCD
        (the one containing the directory /) is located on a UFS device.
  config SCSI_UFSHCD_PCI
-    tristate "PCI bus based UFS Controller support"
+    tristate "PCI bus-based UFS Controller support"

Even with this change applied capitalization is inconsistent.

I don't doubt it, but could you be more explicit about
which word(s) you mean, please?

I see one "pci" in the Kconfig file.
I see several "Controller" vs. "controller."
I see a few of "Support" vs. "support."

Which are you referring to? (or something else)

thanks.
--
~Randy